Skip to content

ALL THE CORES#4496

Merged
runningcode merged 2 commits intomainfrom
no/limit-cores
Jun 19, 2025
Merged

ALL THE CORES#4496
runningcode merged 2 commits intomainfrom
no/limit-cores

Conversation

@runningcode
Copy link
Copy Markdown
Contributor

@runningcode runningcode commented Jun 18, 2025 •
edited
Loading

📜 Description

Use all of them!

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@runningcode
ALL THE CORES
ab2ad2c 
Use all of them!
stefanosiano
stefanosiano approved these changes Jun 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i remember correctly we did this when trying to fix CI freezing randomly.
Our suspect was out of memory because of too many things running at the same time.
Let's do this (things improved in the meantime), and keep it in mind if we have other problems with CI again

@romtsn
Copy link
Copy Markdown
Member

romtsn commented Jun 18, 2025

If i remember correctly we did this when trying to fix CI freezing randomly. Our suspect was out of memory because of too many things running at the same time. Let's do this (things improved in the meantime), and keep it in mind if we have other problems with CI again

yup it was this PR #3814. Unsure if it got better, but we can try again!

@runningcode
Copy link
Copy Markdown
Contributor Author

runningcode commented Jun 18, 2025 •
edited
Loading

Good to know the context. If this is a CI only thing then we should set the workers to 2 only on CI. I’ll do that if this happens again.

@runningcode runningcode merged commit 59389fa into main Jun 19, 2025
32 checks passed
@runningcode runningcode deleted the no/limit-cores branch June 19, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

@lcian lcian Awaiting requested review from lcian

1 more reviewer

@stefanosiano stefanosiano stefanosiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@runningcode @romtsn @stefanosiano