Conversation
adinauer
requested review from
lcian,
markushi,
romtsn and
stefanosiano
as code owners
Contributor
|
Contributor
Performance metrics 🚀
|
adinauer
changed the title
7 tasks
lcian
reviewed
May 12, 2025
| for (Object arg : args) { | ||
| final @NotNull String type = getType(arg); | ||
| attributes.put( | ||
| "sentry.message.parameter." + i, new SentryLogEventAttributeValue(type, arg)); |
Member
There was a problem hiding this comment.
This constructor of SentryLogEventAttributeValue expects a @NotNull as second parameter, while here arg is nullable.
Member
Author
There was a problem hiding this comment.
Good catch. Does seem to allow me to send in null but asked internally what we want to do here.
lcian
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Some basic e2e tests for Logs
Also:
sentry.properties, ENV vars) toexperimental, e.g.experimental.logs.enabledsentry.message.templateif >0 args are presentNULLwhen resolving arg type💡 Motivation and Context
Automated tests
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps