Skip to content

Add API to set custom sentry-native sdk name#2704

Merged
romtsn merged 3 commits intomainfrom
feat/set_native_sdk_name
May 15, 2023
Merged

Add API to set custom sentry-native sdk name#2704
romtsn merged 3 commits intomainfrom
feat/set_native_sdk_name

Conversation

@markushi
Copy link
Copy Markdown
Member

@markushi markushi commented May 9, 2023 •
edited
Loading

📜 Description

Update sentry-native to 0.6.2
Add SentryAndroidOptions.setNativeSdkName

Fixes #2678

💡 Motivation and Context

💚 How did you test it?

Added some unit tests. Ideally we would have some integration test for this as well, but there's nothing setup as of now.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

#skip-changelog

@markushi markushi requested a review from marandaneto May 9, 2023 09:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 9, 2023 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8a89072

@markushi markushi changed the title chore: update sentry-android-ndk/sentry-native to 0.6.2 Add API to set custom sentry-native sdk name May 9, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 9, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 325.10 ms 377.67 ms 52.56 ms
Size 1.72 MiB 2.28 MiB 569.62 KiB

@codecov
Copy link
Copy Markdown

codecov bot commented May 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ba90bd9) 81.05% compared to head (8a89072) 81.05%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #2704   +/-   ##
=========================================
  Coverage     81.05%   81.05%           
  Complexity     4427     4427           
=========================================
  Files           345      345           
  Lines         16356    16356           
  Branches       2219     2219           
=========================================
  Hits          13258    13258           
  Misses         2170     2170           
  Partials        928      928

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn requested a review from krystofwoldrich May 10, 2023 09:32
@romtsn
Copy link
Copy Markdown
Member

romtsn commented May 10, 2023

@krystofwoldrich can you take a look if it's fine for you? we provide setNativeSdkName instead of setNativeClientName because the client name also contains the version of sentry-native, and I guess you don't wanna override that, right?

@markushi
Copy link
Copy Markdown
Member Author

markushi commented May 15, 2023

@marandaneto @krystofwoldrich if there's no objection from your side I'll merge this PR at the end of today.

@romtsn romtsn merged commit 6a11214 into main May 15, 2023
@romtsn romtsn deleted the feat/set_native_sdk_name branch May 15, 2023 15:17
This was referenced May 16, 2023
Closed
Closed
@lucas-zimerman lucas-zimerman mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romtsn romtsn romtsn approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich

+1 more reviewer

@marandaneto marandaneto marandaneto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose setNativeClientName for Hybrid SDKs

4 participants

@markushi @romtsn @marandaneto @web-flow