Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Add frames delay#1153

Merged
philipphofmann merged 6 commits intomasterfrom
feat/frames-delay
Feb 15, 2024
Merged

Add frames delay#1153
philipphofmann merged 6 commits intomasterfrom
feat/frames-delay

Conversation

@philipphofmann
Copy link
Copy Markdown
Member

@philipphofmann philipphofmann commented Feb 12, 2024

Add docs for the performance metric frames delay.

@philipphofmann
Add frames delay
c97c9b3 
Add docs for the performance metric frames delay.
@philipphofmann philipphofmann requested a review from a team February 12, 2024 09:08
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 1:52pm

kahest
kahest reviewed Feb 12, 2024
View reviewed changes
Comment thread src/docs/sdk/performance/frames-delay.mdx
kahest
kahest reviewed Feb 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a clarifying question. I'm pretty familiar with the concept already, so it'll be good to have some more eyes on this

brustolin
brustolin approved these changes Feb 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.
Left a couple of non blocking comments

Comment thread src/docs/sdk/performance/frames-delay.mdx
Comment thread src/docs/sdk/performance/frames-delay.mdx Outdated
@kahest kahest mentioned this pull request Feb 12, 2024
Closed
@stefanosiano
Copy link
Copy Markdown
Contributor

stefanosiano commented Feb 12, 2024 •
edited
Loading

looks good.
I would just clarify explicitly the case of concurrent spans: what happens when 2 spans are running?
should the frame delay be added to both (each with its own value) or only to one of the two?
e.g.
span 1 -> start
span 2 -> start
span 1 -> finish with fdd 10ms
span2 -> finish with fdd 50ms

  • should we send 10 as frame delay for span1 and 50 for span2? (I'd expect this, but there's no mention of this case in the docs)
  • or only 10 to span1 as it started first?
  • or only 50 to span2 as it finished last?

@philipphofmann
Copy link
Copy Markdown
Member Author

philipphofmann commented Feb 13, 2024

@stefanosiano, I updated the docs. Is it clear now how the logic should handle concurrent spans? If not, please tell me how to make it clearer.

markushi
markushi approved these changes Feb 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread src/docs/sdk/performance/frames-delay.mdx Outdated
@philipphofmann philipphofmann enabled auto-merge (squash) February 15, 2024 13:50
@philipphofmann philipphofmann merged commit 58f8ded into master Feb 15, 2024
@philipphofmann philipphofmann deleted the feat/frames-delay branch February 15, 2024 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@kahest kahest kahest left review comments

@markushi markushi markushi approved these changes

@brustolin brustolin brustolin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@philipphofmann @stefanosiano @markushi @kahest @brustolin