Repository navigation
feat: Phase 1 diff/context extractor with parser hardening - #2
Merged
Merged
Conversation
- DiffExtractor with staged, three-dot branch, and rev-range modes over real git subprocess - Explicit -M rename detection plus -z NUL-separated numstat parsing, merged keyed by path - Gitignore-flavored ignore filters (dir prefixes, bare basenames) with user overrides - debug-diff command with per-mode flags and --summary table-only output - Scratch-repo fixtures with rename detection forced off; 33 tests green
This was referenced Sep 9, 2026
getdownandcode
added a commit
that referenced
this pull request
Sep 19, 2026
…d orchestrator consolidation - #1 (Blocker): Fail loud with exit code 1 on git errors, budget cap breaches, and gh CLI errors across pr-summary and changelog CLI commands. - #2: Prevent duplicate printing when no changes/commits exist by early returning None. - #3: Route diagnostic warnings, budget alerts, and error messages to stderr console (err_console) to keep stdout clean for Unix piping. - #4: Correctly parse and surface breaking changes (exclamation mark and BREAKING CHANGE: footers) in conventional commits and templates. - #5: Bump changelog template to version 2, including from_ref..to_ref range and explicit release headers. - #6: Support --title (-t) flag in pr-summary and propagate gh pr create failures. - #7: Remove dead head argument from fallback PR summary. - #8: Consolidate duplicate budget checking, safe telemetry recording, and heuristic token counters into orchestrator.py. - #9: Enforce strict type hints with CommitLogEntry in fallback.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements Phase 1 diff/context extraction as specified in
plan.mdwith complete ambient git isolation and parser hardening.Changes Included
src/gitmate/diff_extractor.py):staged()), branch-to-branch (branch_comparison()), and rev range (rev_range()).FileDiffoutput with addition/deletion counts, status, patch text, and binary detection.ignore_globs.-c core.quotepath=false -c diff.mnemonicPrefix=false --src-prefix=a/ --dst-prefix=b/ --no-color --no-ext-diff --no-textconv.C) status codes.src/gitmate/cli.py):gitmate debug-diffcommand with--base,--from-ref,--to-ref, and--summaryflags.gitmate config showdisplays activeignore_globs.ConfigError,NotAGitRepo, andGitCommandError(exit code 1, no traceback).diff.mnemonicPrefix=true,diff.renames=false).Verification
pytest: 43/43 passedruff check .: passedruff format --check .: passedmypy src tests --strict: passed