[1.7][maxmind] fix provider encondig. Force utf8. - #268

Why not encode the whole file? This has some performance and memory issues.

@Baachi could explain how binary file could be encoded?

Hm this is a good question. I just google the problem and everyone suggest to use utf8_encode or mb_convert_encoding.

too many failed tests. I believe it is not me.

The tests didn't pass because the data from the differend providers has been changed.

@willdurand any chance to merged it?

Do we really need this?

@willdurand just comment the fix and see how the test would fail

But the lib should not alter the encoding...

But the lib should not alter the encoding...

well, yes in a perfect world. Here it is well known problem. As far as I can see it is the only one solution to get the right info.

First I tried to fix encoding in the project code but it appeared to be too late, it simply did not work. Somewhere after MaxmindBinaryProvider and before project code it is completely corrupted (I did not debug so I cannot say where exactly).

Also I found that you did exact same fix in the GeoIpProvider.

Also I found that you did exact same fix in the GeoIpProvider.

Ah, then I'm screwed! :D

So, could you create a fixEncoding() method to the AbstractProvider and relies on it in both GeoIpProvider and MaxmindBinaryProvider?

@willdurand

So, could you create a fixEncoding() method to the AbstractProvider

done - formapro-forks@3c90e66

Great, thanks!

Tagged 1.7.1