Skip to content

Use component categories from frequenz-client-common - #161

Draft
llucax wants to merge 5 commits into
frequenz-floss:v0.x.xfrom
llucax:client-common
Draft

Use component categories from frequenz-client-common#161
llucax wants to merge 5 commits into
frequenz-floss:v0.x.xfrom
llucax:client-common

Conversation

@llucax

@llucax llucax commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Use ComponentCategory from frequenz-client-common
  • Allow for unknown categories in Component
  • Use enum_from_proto() from frequenz-client-common

Fixes #160.

llucax added 5 commits June 27, 2025 10:36
@llucax
Bump frequenz-client-common to v0.3.3
6b132d8 
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Use ComponentCategory from frequenz-client-common
c2f983f 
This allows for better interoperability with other API clients.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Allow for unknown categories in Component
07dd669 
Now an `unknown` category will be stored as a raw `int` instead of
being converted to `UNSPECIFIED`.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Use enum_from_proto() from frequenz-client-common
7d283f8 
This means we can remove `component_category_from_protobuf()` and now
unknown categories will be preserved.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Update release notes
7b8bf8f 
Signed-off-by: Leandro Lucarella <[email protected]>
@github-actions github-actions Bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:client Affects the client code labels Jun 27, 2025
@llucax llucax added the type:enhancement New feature or enhancement visitble to users label Jun 27, 2025
@llucax llucax self-assigned this Jun 27, 2025
@llucax
llucax requested a review from Marenz June 27, 2025 09:09
@llucax

llucax commented Jun 27, 2025

Copy link
Copy Markdown
Contributor Author

@llucax llucax modified the milestone: v0.10.0 Jun 27, 2025

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Marenz Marenz Awaiting requested review from Marenz

At least 1 approving review is required to merge this pull request.

Assignees

See More

@llucax llucax

Labels

part:client Affects the client code part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:enhancement New feature or enhancement visitble to users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use ComponentCategory from frequenz.client.common

1 participant

@llucax