Implemented function call without parameters and subselects as fields#18
Merged
andykent merged 4 commits intoforward:masterfrom Oct 19, 2015
haskellcamargo:master
Merged
Implemented function call without parameters and subselects as fields#18andykent merged 4 commits intoforward:masterfrom haskellcamargo:master
andykent merged 4 commits intoforward:masterfrom
haskellcamargo:master
Conversation
Contributor
Author
|
Solves #17 |
andykent
added a commit
that referenced
this pull request
Oct 19, 2015
Implemented function call without parameters and subselects as fields
Contributor
|
Hi sorry, I was away for a few days but this looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, the following are valid:
SELECT (SELECT A FROM B) FROM CSELECT A(B(C())) FROM DAdditions to grammar:
Expression
o "SubSelectExpression"UserFunction
o "LITERAL LEFT_PAREN RIGHT_PAREN"This, before, would generate a syntax error.
Also, I included a require directive to
coffee-script/register, that is necessary to build viacake build.