Bug fix and feature enhancement#12
Merged
Merged
Conversation
|
@evilscientress If you want to open this pull request against my repo, I'll merge it in. https://github.com/nzlosh/python-icinga2api |
|
@evilscientress you can ignore my request, someone has already merged existing pull requests: https://github.com/joni1993/icinga2apic |
Contributor
Author
|
@nzlosh ok! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a bug in event streaming mode, namely the byte array returned by
request.iter_contentneeds to be decoded to a string.Additionally I added a small feature enhancement. Object requests now decode and add the json error message returned by Icinga to the exception raised on requests with non 2xx result codes.