[DO NOT MERGE] Trigger intentional golden test diff to test Skia Gold notifications - #191505
Open
andywolff wants to merge 1 commit into
Open
[DO NOT MERGE] Trigger intentional golden test diff to test Skia Gold notifications#191505andywolff wants to merge 1 commit into
andywolff wants to merge 1 commit into
Conversation
github-actions
Bot
added
engine
andywolff
changed the title
andywolff
marked this pull request as ready for review
August 21, 2026 19:21
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
Author
|
Confirmed that the desired golden warning was not attached to this PR. Looking at https://flutter-gold.skia.org/changelists to find my PR, I see the impacted goldens at https://flutter-gold.skia.org/search?issue=191505&crs=github&patchsets=1&corpus=flutter I merged a fix to cocoon, so I'll try rebasing this PR after it goes live to verify the fixed behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercises #191483
I changed the paint color in
DlGoldenTest.CanDrawPaintfrom cyan to yellow toproduce an intentional golden image diff in
impeller_golden_tests.This PR tests whether the
flutter-goldstatus check, theflutter-dashboardtriage comment, and the
will affect goldenslabel are properly triggered onCI presubmit runs.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.