[framework] Remove no-shuffle tags and clean up leaked test state - #191499
Draft
bkonyi wants to merge 2 commits into
Draft
[framework] Remove no-shuffle tags and clean up leaked test state#191499bkonyi wants to merge 2 commits into
bkonyi wants to merge 2 commits into
Conversation
Remove the `no-shuffle` tag and associated TODO comments from: - `packages/flutter/test/material/dropdown_test.dart` - `packages/flutter/test/material/progress_indicator_test.dart` - `packages/flutter/test/material/scrollbar_test.dart` Fix test order dependency and state leakage in `scrollbar_test.dart`: - Clean up active mouse pointers in hover tests using `removePointer()`. - Release gestures and pointers in drag tests. - Provide explicit `Theme` contexts and platform-specific painter assertions in `Scrollbar` painting tests to prevent host-platform fallback theme leakage. Fixes flutter#85160
Remove the `no-shuffle` tag declarations from `dart_test.yaml` configurations and delete obsolete `dart_test.yaml` files that only contained `no-shuffle`. Also remove the remaining `no-shuffle` tags from `text_field_test.dart`, `overall_experience_test.dart`, and `gen_defaults_test.dart`. Fixes flutter#85160
|
This pull request contains changes to Material or Cupertino, which are currently frozen in this repository. Changes should be made in Please refer to #188444 for instructions. |
github-actions
Bot
added
a: tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
no-shuffletag declarations and usages across the repository, and fix test state leaks and platform dependencies in Material tests.Changes
scrollbar_test.dart: Added pointer removal (removePointer()) and gesture release (up()) to prevent active pointer persistence across shuffled test runs. Wrapped scrollbar paint tests in explicitThemecontexts and updated paint count expectations to match each target platform.no-shuffleTag Removals:no-shuffletags fromdropdown_test.dart,progress_indicator_test.dart,scrollbar_test.dart,text_field_test.dart,overall_experience_test.dart, andgen_defaults_test.dart.no-shuffletag declarations frompackages/flutter/dart_test.yamlandpackages/flutter_tools/dart_test.yaml.dart_test.yamlfiles containing onlyno-shuffle(dev/tools/gen_defaults/dart_test.yaml,packages/flutter_driver/dart_test.yaml,packages/flutter_test/dart_test.yaml).Fixes #85160
Pre-launch Checklist
///).