Wrap the label widget of the Chip in a Flexible. (#11523) - #11554
Merged
Conversation
ameiyil
commented
Aug 8, 2017
ameiyil
commented
Contributor
- This allows the Chip to constrain the size of its content after taking into account the space occupied by the avatar and delete icon (if they are present)
* This allows the Chip to constrain the size of its content after taking into account the space occupied by the avatar and delete icon (if they are present)
Contributor
|
This needs tests, to verify that chips are acting as expected in various scenarios (most notably, the case you don't want us to regress!). |
Hixie
reviewed
Aug 9, 2017
| /// Optionally, adding an avatar or delete icon to the chip should not | ||
| /// cause the chip or label to exceed its constrained size. | ||
| Future<Null> _testConstrainedLabel(WidgetTester tester, | ||
| {CircleAvatar avatar, VoidCallback onDeleted}) async { |
Contributor
There was a problem hiding this comment.
Please format this more like this:
Future<Null> _testConstrainedLabel(WidgetTester tester, {
CircleAvatar avatar, VoidCallback onDeleted,
}) async {
Contributor
|
This is great, thanks! Let me know when you've adjusted the formatting and I'll land it for you! |
Contributor
Author
|
Adjustment to formatting done! Thanks for the call-out and quick review! |
Contributor
|
Thanks! Will land on green. |
Contributor
Author
|
Friendly ping. |
Contributor
|
Oops, sorry! Landing now! Thanks again! |
|
This merge breaks the Sample code; Error log; If I revert this commit it goes back to working. |
Contributor
|
I'm working on a fix. |
Contributor
|
Fix in #11669 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.