Skip to content

Commit ceeaa80

Browse files
committed
Migrated client.js to be used with require()
1 parent b15eab1 commit ceeaa80

6 files changed

Lines changed: 7 additions & 10 deletions

File tree

Jakefile.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,9 @@
208208
wwp: true,
209209

210210
// Browserify
211-
module: false,
212211
require: false,
212+
module: false,
213+
exports: false,
213214

214215
// Mocha / expect.js
215216
describe: false,

src/client/_client_test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
(function() {
55
"use strict";
66

7+
var client = require("./client.js");
78
var HtmlElement = require("./html_element.js");
89

910
mocha.setup({ignoreLeaks: true});
@@ -17,12 +18,12 @@
1718
documentBody = new HtmlElement($(document.body));
1819
drawingArea = HtmlElement.fromHtml("<div style='height: 300px; width: 600px'>hi</div>");
1920
drawingArea.appendSelfToBody();
20-
svgCanvas = wwp.initializeDrawingArea(drawingArea);
21+
svgCanvas = client.initializeDrawingArea(drawingArea);
2122
});
2223

2324
afterEach(function() {
2425
drawingArea.remove();
25-
wwp.drawingAreaHasBeenRemovedFromDom();
26+
client.drawingAreaHasBeenRemovedFromDom();
2627
});
2728

2829
it("should have the same dimensions as its enclosing div", function() {

src/client/_svg_canvas_test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
afterEach(function() {
2222
div.remove();
23-
wwp.drawingAreaHasBeenRemovedFromDom();
2423
});
2524

2625
it("returns height and width", function() {

src/client/client.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ window.wwp = window.wwp || {};
1212
var start = null;
1313
var drawingArea;
1414

15-
wwp.initializeDrawingArea = function(htmlElement) {
15+
exports.initializeDrawingArea = wwp.initializeDrawingArea = function(htmlElement) {
1616
if (svgCanvas !== null) throw new Error("Client.js is not re-entrant");
1717
drawingArea = htmlElement;
1818

@@ -21,7 +21,7 @@ window.wwp = window.wwp || {};
2121
return svgCanvas;
2222
};
2323

24-
wwp.drawingAreaHasBeenRemovedFromDom = function() {
24+
exports.drawingAreaHasBeenRemovedFromDom = wwp.drawingAreaHasBeenRemovedFromDom = function() {
2525
svgCanvas = null;
2626
};
2727

src/client/html_element.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// Copyright (c) 2013 Titanium I.T. LLC. All rights reserved. See LICENSE.txt for details.
22
/*global $, jQuery, TouchList, Touch */
33

4-
window.wwp = window.wwp || {};
5-
64
(function() {
75
"use strict";
86

todo.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ Engineering Tasks:
2222
- Use Modernizr to eliminate duplicate browserSupportsTouchEvents() function (in _client_test.js & _dom_element_test.js)
2323

2424
To Do on current task:
25-
- Get tests working with require()
26-
- Migrate HtmlElement and client tests to use require()
2725
- Get index.html working with require()
2826
- Figure out how to bundle vendor files
2927
- What about deployment? (Punt?)

0 commit comments

Comments
 (0)