feat(ci): request charlie review only after CI passes - #68
faultless-casey wants to merge 2 commits into
Conversation
Remove CharlieHelps as reviewer on every push, then re-add via the review pipeline only once the GitHub Actions check suite completes successfully. Excludes check suites from third-party apps (coderabbit, vercel, cloudflare, sentry, render, charliecreates) to avoid redundant triggers. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe workflow file is updated to integrate check_suite completion events as an additional trigger alongside pull_request and workflow_call events. The pipeline job's execution conditions and concurrency group logic are expanded to recognize successful check_suite runs with associated pull requests. The version job is restricted to run only on pull_request and workflow_call events via a new conditional guard. A new remove-reviewer job is introduced to remove CharlieHelps from requested reviewers for pull_request events. Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/charlie-review.yml (1)
24-31: 💤 Low valueConsider logging unexpected errors.
The empty
catch {}silently swallows all errors, including legitimate failures (auth issues, rate limits, network errors). A 404 when the reviewer isn't assigned is expected, but other errors may warrant logging.🔧 Optional: Log unexpected errors
try { await github.rest.pulls.removeRequestedReviewers({ owner: context.repo.owner, repo: context.repo.repo, pull_number: context.payload.pull_request.number, reviewers: ['CharlieHelps'], }); - } catch {} + } catch (error) { + // 404 is expected if reviewer wasn't assigned + if (error.status !== 404) { + core.warning(`Failed to remove reviewer: ${error.message}`); + } + }
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 957072c6-7206-46d3-a0ee-da9f9b807062
📒 Files selected for processing (1)
.github/workflows/charlie-review.yml
null != '' evaluates to true in GitHub Actions expressions, so the previous guard did not prevent the pipeline from running when no PR was associated with the check suite. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
Closing this in favour of a new implementation using workflow_run instead of check_suite — check_suite doesn't fire for GitHub Actions check suites. |
1 participant
Summary
pull_requestevent (open, reopen, sync, ready for review), removes CharlieHelps as a reviewer so stale review requests are cleared on each pushcheck_suite: completedtrigger that re-adds Charlie via the review pipeline only when a GitHub Actions suite passesversionjob to only run onpull_requestandworkflow_callevents, not on every check suite completionTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Note: No user-visible changes; updates affect internal CI/CD processes.