Skip to content

feat(ci): add JUnit XML test report rendering to ci-svelte-e2e - #61

Merged
faultless-casey merged 1 commit into
mainfrom
casey/junit-svelte-e2e
May 3, 2026
Merged

faultless-casey merged 1 commit into
mainfrom
casey/junit-svelte-e2e

Conversation

@faultless-casey

@faultless-casey faultless-casey commented May 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Mirrors the dorny/test-reporter@v1 step from ci-e2e.yml into ci-svelte-e2e.yml for Svelte-only consumers like fx-glass/buffalo.

  • Adds checks: write to permissions
  • Adds E2E test report step after "Run Playwright tests", before "Upload test report"
  • path: 'test-results/junit.xml' — root-level, no frontend*/ prefix since Svelte libs have no subdirectory structure
  • name: 'e2e / results N' — no matrix.suite in this workflow, so the check name omits it

Consumers need ["junit", { outputFile: "test-results/junit.xml" }] in their Playwright reporter config to get summaries; those without it see the step pass silently via continue-on-error: true.

Test plan

  • Run CI on a fx-glass/buffalo PR — verify e2e / results 1 and e2e / results 2 check runs appear on the PR checks tab with inline test summaries
  • Verify a consumer without junit.xml sees the step pass silently

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Enhanced CI/CD pipeline with improved test reporting capabilities to provide better visibility into test execution results.

Note

Add JUnit XML test report rendering to the Svelte E2E CI workflow

Adds a post-run step to the ci-svelte-e2e.yml workflow that publishes E2E test results from test-results/junit.xml to GitHub Checks using dorny/test-reporter@v1. The step always runs (unless cancelled) and is configured with fail-on-error: false so reporting failures do not block the job. The workflow also gains checks: write permission required by the reporter action.

Macroscope summarized 2b3f337.

Mirrors the dorny/test-reporter@v1 step from ci-e2e.yml for the
Svelte-only workflow. No matrix.suite here so check names are
"e2e / results N". Adds checks: write permission.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@coderabbitai

coderabbitai Bot commented May 3, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The GitHub Actions CI workflow for Svelte E2E tests has been updated to add test reporting capabilities. The workflow permissions were extended to include checks: write permission alongside existing permissions. A new step was added that publishes JUnit test results from test-results/junit.xml using the dorny/test-reporter action with java-junit format. This reporting step is configured to run unconditionally (when not cancelled) and will not cause the workflow to fail if reporting encounters an error.

Suggested reviewers

  • CharlieHelps
  • macroscopeapp
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding JUnit XML test report rendering to the ci-svelte-e2e workflow. It is concise, specific, and clearly communicates the primary modification.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch casey/junit-svelte-e2e

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot requested a review from CharlieHelps May 3, 2026 21:59
@macroscopeapp

macroscopeapp Bot commented May 3, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved

Adds JUnit test report rendering to CI workflow with appropriate permissions. This is a non-breaking CI enhancement that doesn't affect runtime behavior.

You can customize Macroscope's approvability policy. Learn more.

@faultless-casey
faultless-casey merged commit 67d1a51 into main May 3, 2026
5 checks passed
@faultless-casey
faultless-casey deleted the casey/junit-svelte-e2e branch May 3, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant