perf(ci): Vite deps cache + per-suite e2e sharding - #59

.github/workflows/ci-e2e.yml (1)

155-162: 💤 Low value

Cache implementation looks good; consider dynamic paths for future-proofing.

The cache step is correctly placed and configured. However, the hardcoded paths (frontend/node_modules/.vite, frontend-book/node_modules/.vite) differ from the dynamic suite discovery pattern used at lines 70-73. If a new frontend*/ directory is added in the future, it won't benefit from Vite caching until these paths are updated.

This is a minor maintainability consideration rather than a functional issue, since the current structure is stable and the cache will work correctly as-is.

♻️ Optional: generate cache paths dynamically

You could align with the suite discovery logic by generating paths dynamically, though this adds complexity for marginal benefit:

      - name: Prepare Vite cache paths
        id: vite-paths
        run: |
          paths=()
          for dir in frontend*/; do
            [ -d "$dir" ] || continue
            paths+=("${dir}node_modules/.vite")
          done
          # Convert to multiline string for cache action
          printf 'paths<<EOF\n' >> "$GITHUB_OUTPUT"
          printf '%s\n' "${paths[@]}" >> "$GITHUB_OUTPUT"
          printf 'EOF\n' >> "$GITHUB_OUTPUT"

      - name: Cache Vite pre-bundled deps
        uses: actions/cache@v5
        with:
          path: ${{ steps.vite-paths.outputs.paths }}
          key: vite-deps-${{ runner.os }}-${{ hashFiles('frontend*/pnpm-lock.yaml', 'frontend*/vite.config.ts') }}
          restore-keys: vite-deps-${{ runner.os }}-