Skip to content

Pin flake8 below 4.0.0 - #20

Closed
KPLauritzen wants to merge 1 commit into
flakehell:masterfrom
KPLauritzen:patch-1
Closed

KPLauritzen wants to merge 1 commit into
flakehell:masterfrom
KPLauritzen:patch-1

Conversation

@KPLauritzen

Copy link
Copy Markdown

Current version of flakehell does not work with flake8 above 4.0. Pin down flake8 until flakehell has caught up.

Temporarily fixes #18 .
Can fix #19 if a new release is cut.

TeoZosa added a commit to TeoZosa/cookiecutter-cruft-poetry-tox-pre-commit-ci-cd that referenced this pull request Oct 12, 2021
TeoZosa added a commit to TeoZosa/cookiecutter-cruft-poetry-tox-pre-commit-ci-cd that referenced this pull request Oct 12, 2021
teo-cicd-bot pushed a commit to TeoZosa/cookiecutter-cruft-poetry-tox-pre-commit-ci-cd-instance that referenced this pull request Oct 12, 2021
TeoZosa added a commit to TeoZosa/cookiecutter-cruft-poetry-tox-pre-commit-ci-cd that referenced this pull request Oct 12, 2021
TeoZosa added a commit to TeoZosa/structlog-sentry-logger that referenced this pull request Oct 12, 2021
@mlech-payability

Copy link
Copy Markdown

Closes #22

@and-semakin and-semakin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgaynetdinov please consider merging this PR and cutting a new minor release.

@mcarans

mcarans commented Nov 8, 2021

Copy link
Copy Markdown

Of interest to those still watching this PR, I have made a PR to fix flakehell for flake8 4.0.x. Unfortunately, as with this PR, there is no response. I have raised an issue to ask if this project is still being maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Flakehell fails with pre-commit Flakehell fails with flake8==4.0.0

5 participants