Activity

1. Jaakkonen commented on Mar 9, 2021

   

   Jaakkonen

   on Mar 9, 2021

   More actions

   I got a environment setup as follows:

   python -m venv venv
   . ./venv/bin/activate
   git clone https://github.com/flakehell/flakehell.git
   cd flakehell
   pip install flit  # Dependency manager used in this project
   flit install --deps=all  # Install `tool.flit.metadata.requires-extra.{dev,docs}` in addition to `tool.flit.metadata.requires`
   pytest
   

   With my Python version 3.9.2 following tests fail out of the box:

   ======================================== short test summary info =========================================
   FAILED tests/test_logic/test_extractors.py::test_smoke_extract[flake8-annotations-complexity] - AttributeError: type object 'AnnotationsComplexityChecker' has no attribute '_error_message_template'
   FAILED tests/test_logic/test_extractors.py::test_smoke_prefixes[flake8-annotations-complexity] - AttributeError: type object 'AnnotationsComplexityChecker' has no attribute '_error_message_template'
   ============================= 2 failed, 186 passed, 4694 warnings in 16.98s ==============================
   

   This seems to be a regression of best-doctor/flake8-annotations-complexity@93cadc3

   I personally prefer poetry or just plain old venv & pip for my projects but flit seems to have pyproject.toml support too without also taking care of the virtual environment stuff too.
2. ChadBailey commented on Apr 8, 2021

   

   ChadBailey

   on Apr 8, 2021

   Last edited by ChadBailey

   Author

   More actions

   Sorry I forgot about this, I need to figure out a way to stop forgetting to check github for notifications :(

   I didn't realize flit was in use for this project, thanks for calling that out! I may try and give this a stab over the weekend...

   That said, I'm only vaguely familiar with flit but based on my understanding pipenv and flit offer different functions and can be used together. The very last sentence of "Why use Flit?" addresses this:

   "Flit also doesn’t help you manage dependencies: you have to add them to pyproject.toml by hand. Tools like Poetry and Pipenv have features which help add and update dependencies on other packages."

   Edit: I'm still researching best options, seems there's no clear path forward in Python packaging right now with so many competing standards.