Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Initialize a breakpoint as loading true - redo of PR 7644#7803

Closed
saranti wants to merge 2 commits into
firefox-devtools:masterfrom
saranti:loadingbug
Closed

Initialize a breakpoint as loading true - redo of PR 7644#7803
saranti wants to merge 2 commits into
firefox-devtools:masterfrom
saranti:loadingbug

Conversation

@saranti

@saranti saranti commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

Redo of #7644
Fixes bug #6771

@bomsy

bomsy commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

@art-vanderlay thanks ... will take a look in a bit

@darkwing

Copy link
Copy Markdown
Contributor

Test failure is legit; if I create a breakpoint, then refresh, the breakpoint is gone.

@art-vanderlay Here's an idea. Let's audit if loading is actually being used anywhere. If it isn't, we could just remove it.

@darkwing

darkwing commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

I'm going to park this one @art-vanderlay; it's good work but we're restructuring breakpoints work and we'll incorporate this fix as part of the larger change. Thank you!

@darkwing darkwing closed this Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants