Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Initialize a breakpoint as loading#7644

Closed
saranti wants to merge 0 commit into
firefox-devtools:masterfrom
saranti:master
Closed

Initialize a breakpoint as loading#7644
saranti wants to merge 0 commit into
firefox-devtools:masterfrom
saranti:master

Conversation

@saranti

@saranti saranti commented Jan 3, 2019

Copy link
Copy Markdown
Contributor

Fixes #6771

Latest attempt to initialize loading as true

@darkwing

darkwing commented Jan 4, 2019

Copy link
Copy Markdown
Contributor

Presumably we'd need to set this to false somewhere, which may be why tests are failing.

@saranti

saranti commented Jan 10, 2019

Copy link
Copy Markdown
Contributor Author

@darkwing No dice. Maybe I should leave this for someone more knowledgeable than me

@darkwing

Copy link
Copy Markdown
Contributor

@AnshulMalik or @bomsy, could you take a look at this? I've tried this in the past and ran into the same issues.

"hidden": false,
"id": "foo",
"loading": false,
"loading": true,

@princiya princiya Jan 11, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loading is false in src/actions/breakpoints/index.js, but all the following snapshots have loading is true. Could this be the reason for the failing tests?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing when loading was false in the snapshot. The circle test was failing as well

@AnshulMalik

Copy link
Copy Markdown
Contributor

This is more complex than I thought it would be, I'll try to look into it tonight.

@darkwing

Copy link
Copy Markdown
Contributor

Any progress here @AnshulMalik ?

@AnshulMalik

Copy link
Copy Markdown
Contributor

Yeah, there seems to be some issue with breakpoints not persisting aka pending breakpoints.
Not sure why this is happening though. Will try again

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants