This repository was archived by the owner on Jan 11, 2023. It is now read-only.
New Breakpoints UI: Group Breakpoints#5845
Merged
Merged
Conversation
darkwing
commented
Apr 2, 2018
| hitCount, | ||
| generatedLocation: newGeneratedLocation | ||
| generatedLocation: newGeneratedLocation, | ||
| text: breakpoint.text |
Contributor
Author
There was a problem hiding this comment.
This is temporary; should be removed once #5823 is merged.
darkwing
commented
Apr 2, 2018
| cursor: default; | ||
| flex-grow: 1; | ||
| text-overflow: ellipsis; | ||
| overflow: hidden; |
Contributor
Author
There was a problem hiding this comment.
This CSS ensures that the breakpoint code gets the most space but is also ellipsis'd
darkwing
commented
Apr 2, 2018
| } | ||
|
|
||
| // THIS SHOULD BE DELETED | ||
| function renderSourceLocation(source, line, column) { |
Contributor
Author
There was a problem hiding this comment.
This can probably go now.
darkwing
commented
Apr 2, 2018
| hidden: hidden || false, | ||
| loading: false, | ||
| text: "", | ||
| text: condition ? condition : "NOT CONDITIONAL", |
Contributor
Author
There was a problem hiding this comment.
This is obviously hardcoded and undesirable.
darkwing
force-pushed
the
group-breakpoints
branch
from
April 2, 2018 21:54
cdd33dc to
8361203
Compare
darkwing
changed the title
jasonLaster
approved these changes
Apr 3, 2018
jasonLaster
left a comment
jasonLaster
left a comment
Contributor
There was a problem hiding this comment.
Yes!!! Really exciting
| ); | ||
|
|
||
| return <div className="pane breakpoints-list">{children}</div>; | ||
| forOwn(groupedBreakpoints, (breakpointsInFile, filename) => { |
Contributor
There was a problem hiding this comment.
map is generally the preference here
Contributor
Author
There was a problem hiding this comment.
groupedBreakpoints is an object literal so I'd need to use Object.keys() and so on; I thought forOwn was simple enough.
|
|
||
| return ( | ||
| <div className="pane breakpoints-list"> | ||
| {children.length ? ( |
Contributor
There was a problem hiding this comment.
it might be nice to split it up and at the top do
return <div className="pane breakpoints-list">
{this.isEmpty() ? this.renderEmptyList() : this.renderBreakpointGroups() }
</div>then below
return groups.map(group => <div>{group.breakpoints.map(this.renderBreakpoint)}</div>))
darkwing
force-pushed
the
group-breakpoints
branch
from
April 3, 2018 20:16
4817bb1 to
81faad0
Compare
Contributor
|
|
jasonLaster
pushed a commit
that referenced
this pull request
Apr 9, 2018
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Apr 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #5796
This is a WIP for the grouping of breakpoints for the new breakpoints UI.
ToDo
renderSourceLocationfunction once I'm confident all its contents are accounted forI'm thinking that syntax highlighting via CodeMirror can be done as a separate PR since it will likely require more thought and, IMO, shouldn't block this.
Screenshots