This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix for #4469 Right-click in editor window shows 2 context menus#4470
Merged
Conversation
jasonLaster
reviewed
Oct 23, 2017
| codeMirror.on("contextmenu", (cm, event) => { | ||
| event.stopPropagation(); | ||
| event.preventDefault(); | ||
| return this.openMenu(event); |
Contributor
There was a problem hiding this comment.
minor point, but for aesthetics can we move event.stopPropagation and event.preventDefault to openMenu. It'll only ever be called here
Contributor
Author
|
There is one more bug here. Seems like codemirror issue
|
Contributor
|
we can ignore the 2nd issue.. it's only true in the launchpad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #4469
Summary of Changes
Test Plan
Screenshots/Videos (OPTIONAL)