Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Remove yarn version from docs and circle config#2497

Closed
clarkbw wants to merge 6 commits into
firefox-devtools:masterfrom
clarkbw:yarn-version
Closed

Remove yarn version from docs and circle config#2497
clarkbw wants to merge 6 commits into
firefox-devtools:masterfrom
clarkbw:yarn-version

Conversation

@clarkbw

@clarkbw clarkbw commented Mar 30, 2017

Copy link
Copy Markdown
Contributor

Associated Issue: #2475

Summary of Changes

I don't believe we need to ensure a version of yarn anymore. Now that the package has stabilized we can likely trust the latest stable version instead of a custom 0.19.1 version.

  • removed yarn version requirements from circle ci config
  • removed yarn version suggestions in docs

Test Plan

  • run this on circle
  • try to pass local tests

@jasonLaster jasonLaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jasonLaster

Copy link
Copy Markdown
Contributor

Hmm, looks like we still need to install yarn

@clarkbw

clarkbw commented Mar 30, 2017

Copy link
Copy Markdown
Contributor Author

Strange, we don't need to do that for devtools-core https://github.com/devtools-html/devtools-core/blob/master/circle.yml

@clarkbw

clarkbw commented Mar 30, 2017

Copy link
Copy Markdown
Contributor Author

Oh right, I remember now. We are on a linux build that works for our Docker system but doesn't have yarn installed by default. Will put those pieces back.

@clarkbw clarkbw mentioned this pull request Mar 30, 2017
@clarkbw clarkbw closed this Mar 30, 2017
@clarkbw
clarkbw deleted the yarn-version branch March 30, 2017 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants