CC @MoLow

@jasonLaster whats this?

Hi, sorry for the delay in answering. In the meanwhile i tested on a computer with no admin priviligaes, so I could not install yarn, neither update node to > 6.9.0, so I tried running it directly, and this is the results:

I'l try it later today on my computer using npm run/yarn start/yarn run.

BTW, I havent tried yet, but this maybe a simple solution: https://www.npmjs.com/package/npm-run-path

yarn start firefox vs yarn run firefox

I believe with yarn start firefox yarn is just actually starting the server and it actually passes 'firefox' as an argument to the server.

When you run yarn run firefox you're seeing the issue we seem to be having running Firefox on windows.

Ok, and I just looked into this further. I think the first solution is to update our instructions.

The error you're seeing in that screenshot is because you don't have the geckodriver.exe file in your local path. Here are some quick instructions so solve this:

• Open https://github.com/mozilla/geckodriver/releases/latest
• Download the build file that matches your system (like geckodriver-v0.11.1-win64.zip)
• Create a local bin directory by doing mkdir ~/bin
• Extract the gecokdriver.exe file into the bin directory you just created

Now when you run yarn run firefox Firefox should start up.

I am seeing a problem where you I don't believe the debugger server is running, looking into that now.

@clarkbw well, the question is if this could be done automatically on npm install or on npm run firefox, since the exe is installed to node_modules\geckodriver, and it only needs to get into the path in runtime.

could be done automatically on npm install or on npm run firefox, since the exe is installed to node_modules\geckodriver, and it only needs to get into the path in runtime.

Yes, sorry. What I have above shouldn't actually be the solution, just short term. On the Mac this is done automatically and it should be on Windows as well.

@clarkbw perhaps look at npm run path issues for windows

Oh, hmm. I'm seeing node_modules/.bin/geckodriver where i believe it should be node_modules/.bin/geckodriver.exe

Or, actually geckodriver.cmd

The .bin/ directory has files with the .cmd extension, which run just fine. I found that if I change this line with a s/exe/cmd/ then it works just fine.

https://github.com/SeleniumHQ/selenium/blob/ba56ad1ae0b98a1fe1efdd2163c62fc847950178/javascript/node/selenium-webdriver/firefox/index.js#L288

I've been trying out this solution, creating the driver manually, but still not having success:

  let options = new firefox.Options();
  let service = new firefox.ServiceBuilder(__dirname + '\\..\\node_modules\\.bin\\geckodriver.cmd').build();

  options.setProfile(firefoxProfile());
  options.setBinary(firefoxBinary());

  const driver = new firefox.Driver(options, service);

It finds the local gecko driver but errors out elsewhere before running anything.

well, now I ran it on another machine, and it seems the correct directory is prepended to PATH - only when running via npm run firefox;

this the result of echo $PATH and adding console.log(process.env.PATH); to firefox-driver.js

however, I created a file called "path.js" which only contains console.log(process.env.PATH);, and the directory is not prepended:

when I changethe firefox command in package.json to node path.js, the path is prepended again:

Mabe the simplest solution is to add these lines to firefox-driver.js?:

var path = require('path'); process.env.PATH = path.resolve(__dirname, '../node_modules/.bin') + ';' + process.env.PATH;

is this a BAD idea?
would it work in linux?

is this a BAD idea?
would it work in linux?

As I understand it, the .bin/ path is being added correctly, however it is looking for geckodriver.exe on windows and that .exe isn't found in that .bin/ path.

I think you need to do something like this:

if (isWindows) { 
var path = require('path'); 
process.env.PATH = path.resolve(__dirname, '../node_modules/geckodriver/bin') + ';' + process.env.PATH; 
}