issue:1248 fix running firefox in debuggable state in windows#1275
issue:1248 fix running firefox in debuggable state in windows#1275devcer wants to merge 1 commit into
Conversation
|
ping @clarkbw, @auchenberg mind doing a sanity check? @viswanathamsantosh mind updating this call site as well so that |
|
I'm getting my windows box updated right now. I'm a bit confused about this though. In #1248 I thought this was just about the dashes. Can someone paste the output of |
|
Also, we should double check Firefox versions here just in case there has been some kind of update I'm not aware of. A subtle change in the args like this would be like winning a lifetime supply of footguns |
|
CC @shlomif, @Garbee, @auchenberg @clarkbw how should we move forward here? I'm tempted to accept and then we can discuss if others find outliers... |
|
Here's the output I get and Firefox says debugger, not debugging. I'll have to try it out to know |
|
Here's the output I get: From this it appears to me that we want |
Also I did test that the connection only works with the above flag. |
|
CC @MoLow |
|
@clarkbw Strange but I dont see any output for |
|
I will into that tomorrow when I'm near my windows box. Can't say I have an idea right now. |
|
Try |
|
closing this PR so we can work on #1309 |
Associated Issue: #1248
Summary of Changes
*Changed to
--start-debugging-serverfrom--start-debugger-serverfor windows environment in CONTRIBUTING.md fileTest Plan
C:\Program Files (x86)\Mozilla Firefox\firefox.exe -start-debugging-server 6080 -P developmenton windows 10