Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

issue:1248 fix running firefox in debuggable state in windows#1275

Closed
devcer wants to merge 1 commit into
firefox-devtools:masterfrom
devcer:master
Closed

issue:1248 fix running firefox in debuggable state in windows#1275
devcer wants to merge 1 commit into
firefox-devtools:masterfrom
devcer:master

Conversation

@devcer

@devcer devcer commented Nov 21, 2016

Copy link
Copy Markdown
Contributor

Associated Issue: #1248

Summary of Changes

*Changed to --start-debugging-server from --start-debugger-server for windows environment in CONTRIBUTING.md file

Test Plan

  • start debuggable version of firefox browser using C:\Program Files (x86)\Mozilla Firefox\firefox.exe -start-debugging-server 6080 -P development on windows 10
  • browser will be launched
  • now restart the development server and launch debugger

@jasonLaster

Copy link
Copy Markdown
Contributor

ping @clarkbw, @auchenberg mind doing a sanity check?

@viswanathamsantosh mind updating this call site as well so that npm run firefox works on windows!

@clarkbw

clarkbw commented Nov 21, 2016

Copy link
Copy Markdown
Contributor

I'm getting my windows box updated right now. I'm a bit confused about this though. In #1248 I thought this was just about the dashes.

Can someone paste the output of C:\Program Files (x86)\Mozilla Firefox\firefox.exe -h ?

@clarkbw

clarkbw commented Nov 21, 2016

Copy link
Copy Markdown
Contributor

Also, we should double check Firefox versions here just in case there has been some kind of update I'm not aware of. A subtle change in the args like this would be like winning a lifetime supply of footguns

@jasonLaster

Copy link
Copy Markdown
Contributor

CC @shlomif, @Garbee, @auchenberg

@clarkbw how should we move forward here? I'm tempted to accept and then we can discuss if others find outliers...

@clarkbw

clarkbw commented Nov 24, 2016

Copy link
Copy Markdown
Contributor

Here's the output I get and Firefox says debugger, not debugging. I'll have to try it out to know

 "C:\Program Files (x86)\Mozilla Firefox\firefox.exe" -h
Usage: C:\Program Files (x86)\Mozilla Firefox\firefox.exe [ options ... ] [URL]
       where options include:

  -h or --help       Print this message.
  -v or --version    Print Firefox version.
  -P <profile>       Start with <profile>.
  --profile <path>   Start with profile at <path>.
  --migration        Start with migration wizard.
  --ProfileManager   Start with ProfileManager.
  --no-remote        Do not accept or send remote commands; implies --new-instance.
  --new-instance     Open new instance, not a new window in running instance.
  --UILocale <locale> Start with <locale> resources as UI Locale.
  --safe-mode        Disables extensions and themes for this session.
  --console          Start Firefox with a debugging console.
  --browser          Open a browser window.
  --new-window <url> Open <url> in a new window.
  --new-tab <url>    Open <url> in a new tab.
  --private-window <url> Open <url> in a new private window.
  --preferences      Open Options dialog.
  --search <term>    Search <term> with your default search engine.
  --jsconsole        Open the Browser Console.
  --jsdebugger       Open the Browser Toolbox.
  --devtools         Open DevTools on initial load.
  --start-debugger-server [port|path] Start the debugger server on a TCP port or Unix domain socket path.  Defaults to TCP port 6000.
  --recording <file> Record drawing for a given URL.
  --recording-output <file> Specify destination file for a drawing recording.
  --setDefaultBrowser Set this app as the default browser.

@clarkbw

clarkbw commented Nov 24, 2016

Copy link
Copy Markdown
Contributor

Here's the output I get:

Bryan@BryanWin10  ~/Documents/GitHub
$ "C:\Program Files (x86)\Mozilla Firefox\firefox.exe" -start-debugger-server 6080 -P dev-edition-default
Started debugger server on 6080

Bryan@BryanWin10  ~/Documents/GitHub
$ "C:\Program Files (x86)\Mozilla Firefox\firefox.exe" -start-debugging-server 6080 -P dev-edition-default

From this it appears to me that we want -start-debugger-server. From the command line like this none of the flags work if you haven't set the about:config values correctly.

@clarkbw

clarkbw commented Nov 24, 2016

Copy link
Copy Markdown
Contributor

From this it appears to me that we want -start-debugger-server

Also I did test that the connection only works with the above flag.

@jasonLaster

Copy link
Copy Markdown
Contributor

CC @MoLow

@devcer

devcer commented Nov 26, 2016

Copy link
Copy Markdown
Contributor Author

@clarkbw Strange but I dont see any output for firefox.exe -h . Any thoughts?
firefox

@clarkbw

clarkbw commented Nov 27, 2016

Copy link
Copy Markdown
Contributor

I will into that tomorrow when I'm near my windows box. Can't say I have an idea right now.

@Garbee

Garbee commented Nov 27, 2016

Copy link
Copy Markdown
Contributor

Try \h. That is typically how windows CLI handles those types of flags.

@jasonLaster

Copy link
Copy Markdown
Contributor

closing this PR so we can work on #1309

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants