Skip to content

[remote_config] Propagate native error message on #fetch#2859

Merged
kroikie merged 2 commits into
firebase:masterfrom
arthurdenner:remote-config/fetch-propagate-native-error
Jun 29, 2020
Merged

[remote_config] Propagate native error message on #fetch#2859
kroikie merged 2 commits into
firebase:masterfrom
arthurdenner:remote-config/fetch-propagate-native-error

Conversation

@arthurdenner

Copy link
Copy Markdown
Contributor

Description

Any error thrown by RemoteConfig.fetch that doesn't have the code fetchFailedThrottled is "swallowed" because we're only returning the string "Unable to fetch remote config". This PR replaces the generic message with the message returned from the native side in order to improve debuggability (if this word exists 😅 ).

Related Issues

I couldn't find one related to this specific problem.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@kroikie kroikie merged commit 322a628 into firebase:master Jun 29, 2020
@arthurdenner arthurdenner deleted the remote-config/fetch-propagate-native-error branch June 30, 2020 08:11
@arthurdenner

arthurdenner commented Jul 1, 2020

Copy link
Copy Markdown
Contributor Author

@kroikie, thank you for the quick review!

Is there any expected date for a new release? I've checked the docs and it says it's a manual process.
I've an issue happening in a project that I can't quite understand due to the generic error.

@firebase firebase locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants