[remote_config] Propagate native error message on #fetch#2859
Merged
kroikie merged 2 commits intoJun 29, 2020
Merged
Conversation
kroikie
approved these changes
Jun 29, 2020
Contributor
Author
|
@kroikie, thank you for the quick review! Is there any expected date for a new release? I've checked the docs and it says it's a manual process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Any error thrown by
RemoteConfig.fetchthat doesn't have the codefetchFailedThrottledis "swallowed" because we're only returning the string "Unable to fetch remote config". This PR replaces the generic message with the message returned from the native side in order to improve debuggability (if this word exists 😅 ).Related Issues
I couldn't find one related to this specific problem.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?