[flutter_analytics_web] Add logEcommercePurchase and logAddToCart#2856
Closed
Bilonik wants to merge 9 commits into
Closed
[flutter_analytics_web] Add logEcommercePurchase and logAddToCart#2856Bilonik wants to merge 9 commits into
Bilonik wants to merge 9 commits into
Conversation
Propagate native error message on Remote Config fetch method
ditman
suggested changes
Jun 30, 2020
ditman
left a comment
ditman
left a comment
Contributor
There was a problem hiding this comment.
Both logEcommercePurchase and logAddToCart methods already exist in package:firebase_analytics.
Please, do not use the platform_interface package directly, only use package:firebase_analytics! :) See the example app on how to use the firebase_analytics plugin.
Note: we're currently working to endorse the web version of the plugin so this works transparently across all platforms, but we had to fix some miscellaneous issues before.
Until the PR above lands, you need to depend on both firebase_analytics and firebase_analytics_web.
Thanks for contributing, but this code does not need to be merged.
Contributor
Author
|
Thank @ditman |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add logEcommercePurchase and logAddToCart to flutter_analytics_web
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?