[cloud_firestore_web] Ensure Query pagination methods encode values.#2166
Merged
Conversation
This change ensures that the package:firestore Query objects are created with properly encoded values when done so from the start/end (pagination) methods. This also adds some Timestamps to the unit tests to verify the behavior of Timestamp -> DateTime. There are some integration tests in cloud_firestore that cover this behavior further. Fixes #2153
Contributor
Author
|
/cc @amrfarid140 |
Contributor
Author
|
(The push above is unrelated. I didn't add a version bump because it's just a minor fix in a test file to appease the analyzer, I'm not planning in publishing that) |
Contributor
|
Ah! this slipped through the cracks when we did it for mobile. Good catch @ditman . |
kroikie
approved these changes
Mar 16, 2020
harryterkelsen
approved these changes
Mar 19, 2020
Contributor
Author
|
I'm merging this, I repeated the last failing check and it passed, and there's 2 approvals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that the package:firestore Query objects are created with properly encoded values when done so from the start/end (pagination) methods.
This also adds some Timestamps to the unit tests to verify the behavior of Timestamp -> DateTime.
(There are some integration tests in cloud_firestore that cover this behavior further.)
Related Issues
Fixes #2153
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?