Basic support for inheritance (based on #247) - #253
Merged
Merged
Conversation
When defining states and transitions in a base class, they are not detected by the sub class. Therefore The StateMachinMetaClass is extended to also take care of the states and transitions of the base classes Issue: #211
…ine into rschrader-develop
Codecov Report
@@ Coverage Diff @@
## develop #253 +/- ##
======================================
Coverage 100% 100%
======================================
Files 5 5
Lines 332 344 +12
Branches 43 45 +2
======================================
+ Hits 332 344 +12
Continue to review full report at Codecov.
|
fgmacedo
commented
Jan 21, 2020
|
|
||
| def __contribute_to_class__(self, managed, identifier): | ||
| self.managed = managed | ||
| def _set_identifier(self, identifier): |
Owner
Author
There was a problem hiding this comment.
managed was a reference to the statemachine class when the State or Transition was defined. Removed as there's no real use-case and can generate conflict with a State now being used on multiple classes due to inheritance.
fgmacedo
force-pushed
the
rschrader-develop
branch
from
January 23, 2020 02:54
7d2290a to
7ba183e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR based on #247.
Copy states and transitions from base classes.
TODO: