Improved types (PHPStan level 6)#1081
Merged
dantleech merged 1 commit intophpbench:masterfrom Jan 25, 2024
Merged
Conversation
aivchen
force-pushed
the
phpstan
branch
4 times, most recently
from
c98ae60 to
31808ba
Compare
Contributor
Author
|
Bump |
dantleech
reviewed
Jan 21, 2024
| for ($index = 0; $index < $nbIterations; $index++) { | ||
| $iteration = $variant->getIteration($index); | ||
|
|
||
| foreach ($variant as $index => $iteration) { |
Member
There was a problem hiding this comment.
Are we sure that index is a sequential list here? Maybe use array_values if not
Contributor
Author
There was a problem hiding this comment.
Yes, we are sure.
- In
lib/Model/Variant.phpwe add values to the private propertyVariant::$iterationsusing only$this->iterations[] = XXX. Variant::$iterationshas/** @var list<Iteration> */docblock. It means this array is 0-based sequential list (https://phpstan.org/writing-php-code/phpdoc-types#lists).
Member
There was a problem hiding this comment.
yes, have some ancient memories about making for loops like that to work around "lists" that had been filtered etc making their array keys non-sequential.
dantleech
reviewed
Jan 25, 2024
| private $maxTime, | ||
| private $meanTime, | ||
| private $meanRelStDev, | ||
| private $totalTime |
Member
|
great work again 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to disable 'void_return' php-cs-fixer rule. Otherwise it adds return type to
\PhpBench\Progress\LoggerInterfaceafter my changes.