Skip to content

fix: 结果操作生成 SQL 时限定表名重复拼接 schema #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feigeCode merged 1 commit into from
Oct 22, 2026
Merged

fix: 结果操作生成 SQL 时限定表名重复拼接 schema #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions crates/db/src/plugin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2460,7 +2460,15 @@ pub trait DatabasePlugin: Send + Sync {
}

/// Format table name for copy SQL (with optional schema)
///
/// SQL 结果网格里的表名来自查询分析（见 `direct_table_identity`），可能是
/// `schema.table` 拼接形式。这类限定名自带前缀，再拼一次 schema 会得到
/// `schema.schema.table` 这种重复引用（issue #400），所以限定名按段引用后
/// 直接使用；裸表名才拼 schema 前缀。
fn format_copy_table_name(&self, schema: Option<&str>, table: &str) -> String {
if qualified_table_parts(table).is_some() {
return self.quote_qualified_table_name(table);
}
let quoted_table = self.quote_identifier(table);
match schema {
Some(s) if !s.is_empty() => {
Expand Down Expand Up @@ -4797,4 +4805,48 @@ mod tests {
)
);
}

/// 结果操作生成 SQL 时，查询分析给出的表名可能是 `schema.table` 拼接形式，
/// 再拼 schema 会得到 `schema.schema.table` 重复引用（issue #400）。
#[test]
fn copy_sql_qualified_table_name_is_not_prefixed_twice() {
let plugin = crate::postgresql::PostgresPlugin::new();
let request = CopySqlRequest {
schema: Some("ads".to_string()),
table: "ads.ads_tb_x".to_string(),
..sample_copy_sql_request()
};
let sql = plugin.generate_copy_insert_sql(&request);
assert!(
sql.contains(r#""ads"."ads_tb_x""#),
"限定表名应按段引用且不重复拼 schema：{sql}"
);
assert!(
!sql.contains(r#""ads"."ads.ads_tb_x""#),
"不应出现重复 schema 引用：{sql}"
);
}

/// 裸表名仍保留 schema 前缀语义，回归保护。
#[test]
fn copy_sql_bare_table_name_keeps_schema_prefix() {
let plugin = crate::postgresql::PostgresPlugin::new();
let request = CopySqlRequest {
schema: Some("ads".to_string()),
table: "ads_tb_x".to_string(),
..sample_copy_sql_request()
};
let sql = plugin.generate_copy_insert_sql(&request);
assert!(
sql.contains(r#""ads"."ads_tb_x""#),
"裸表名应拼上 schema 前缀：{sql}"
);
}

fn sample_copy_sql_request() -> CopySqlRequest {
use crate::TableCellValue;
CopySqlRequest::new("ads.ads_tb_x", vec![])
.with_typed_rows(vec![vec![TableCellValue::Text("1".to_string())]])
.with_column_names(vec!["id".to_string()])
}
}
Loading