Skip to content

fix: Add SSE disconnect event #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 1 commit into from
Mar 19, 2026
+18 −0
Merged

fix: Add SSE disconnect event #3673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/feathers/src/http/sse.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,5 +233,22 @@ describe('SseService', () => {
const result = await iterator.next()
expect(result.done).toBe(true)
})

it('emits disconnect event when generator is closed', async () => {
const generator = await app.service('sse').find(connection)
const iterator = generator[Symbol.asyncIterator]()

await iterator.next() // consume connected event

const disconnectPromise = new Promise<any>((resolve) => {
app.once('disconnect', resolve)
})

await iterator.return()

const disconnectedConnection = await disconnectPromise
expect(disconnectedConnection).toBe(connection)
})

})
})
1 change: 1 addition & 0 deletions packages/feathers/src/http/sse.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export class SseService {
} finally {
isActive = false
app.removeListener('publish', publishHandler)
app.emit('disconnect', connection)
}
}

Expand Down
Loading