Skip to content

feat: Replace query-string with qs@6-compatible bracket-notation parser #3662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 2 commits into from
Feb 19, 2026
Merged

feat: Replace query-string with qs@6-compatible bracket-notation parser #3662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4d6cc4
feat: Replace query-string with qs@6-compatible bracket-notation parser
marshallswain Feb 19, 2026
21254e4
Update client fixture data
daffl Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
131 changes: 0 additions & 131 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion packages/feathers/fixtures/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ export function clientTests(app: any, name: string) {
it('.get and params passing', async () => {
const query = {
returnquery: 'true',
some: ['thing', '2', 'test']
some: 'thing',
other: ['one', 'two'],
nested: { a: { b: 'object' } }
}

const todo = await getService().get('0', { query })
Expand Down
2 changes: 0 additions & 2 deletions packages/feathers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,7 @@
},
"devDependencies": {
"@types/node": "^24.1.0",
"@types/qs": "^6.14.0",
"@vitest/coverage-v8": "^3.2.4",
"qs": "^6.15.0",
"shx": "^0.4.0",
"typescript": "^5.8.0",
"vitest": "^3.2.4"
Expand Down
7 changes: 7 additions & 0 deletions packages/feathers/src/client/fetch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ describe('fetch REST connector', function () {
await expect(() => service.get('notfound', {})).rejects.toBeInstanceOf(NotFound)
})

it('supports nested arrays in queries', async () => {
const query = { test: { $in: ['0', '1', '2'] }, returnquery: 'true' }
const data = await service.get('dishes', { query })

expect(data.query).toEqual(query)
})

it('can initialize a client instance', async () => {
const init = fetchClient(fetch, {
baseUrl: baseUrl
Expand Down
2 changes: 1 addition & 1 deletion packages/feathers/src/client/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { Application, Query } from '../declarations.js'
import { stringify as defaultStringify } from '../query-string.js'
import { stringify as defaultStringify } from '../qs.js'
import { FetchClient, ProxiedFetchClient } from './fetch.js'
import { sseClient, SseClientOptions } from './sse.js'
import { defaultServiceEvents } from '../service.js'
Expand Down
2 changes: 1 addition & 1 deletion packages/feathers/src/http/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Params, Service, Query } from '../index.js'
import type { HookContext, NextFunction } from '../hooks/index.js'
import { BadRequest, FeathersError } from '../errors.js'
import { parse } from '../query-string.js'
import { parse } from '../qs.js'

interface RouteLookup {
service: Service
Expand Down
Loading