Make LengthPrefixedVec generic - #410
Merged
Merged
Conversation
kirawi
commented
Apr 9, 2021
Schuwi
reviewed
Apr 10, 2021
Member
|
Looks very good overall! :) |
Contributor
Author
|
I made the trait return a result, and all other functions simply unwrap it. I'll probably change it to have proper error propagation in the future. |
Contributor
Author
|
Okay, I think it should be good enough for now. Ready for review. In the future, the error handling would likely need to be overhauled since my work was blindly done, and I expect it may eventually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make LengthPrefixedVec generic
Status
Description
Made it generic and added typedefs for compatibility with existing code, and removed
ShortPrefixedVecimplementation. As per this conversation. Honestly, I'm not sure if performance will suffer, but I hope not.Checklist
cargo fmt,cargo clippy,cargo build --releaseandcargo testand fixed any generated errors!