Implement a new inventory API - #221
Merged
Merged
Conversation
Member
|
How are we going to handle serialization? I suspect that we want to serialize directly to NBT format? But are inventory serialization handle separately for tile entities compared to players? |
Member
|
Also, which kinds of operations do we expect users to have a need for? Would these operations be carried out on the entire inventory or a subset, ie hotbar and armor? |
caelunshun
marked this pull request as ready for review
May 18, 2020 17:53
Member
Author
|
@Defman for querying, here's some use cases I can think of:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old inventory design had a key problem: It could not correctly handle slot indexing in different contexts. As per this page, indices in the protocol take different forms depending on the current window. The old API used raw indices based on those used for the main inventory context, but this cannot be extended to work with other windows, such as crafting tables, chests, etc.
The new design hopes to solve the above.
Resolves #79.