Skip to content
This repository was archived by the owner on Dec 8, 2020. It is now read-only.

Initial refactoring#60

Draft
JarvisCraft wants to merge 42 commits into
developmentfrom
refactoring
Draft

Initial refactoring#60
JarvisCraft wants to merge 42 commits into
developmentfrom
refactoring

Conversation

@JarvisCraft
Copy link
Copy Markdown
Member

Initial refactoring of common mistakes in all parts of the API.
This also includes removing Minecraft-related part from this repository.

@JarvisCraft JarvisCraft added bug Something isn't working enhancement New feature or request labels Nov 9, 2019
@JarvisCraft JarvisCraft added this to the Initial release milestone Nov 9, 2019
@JarvisCraft JarvisCraft self-assigned this Nov 9, 2019
@pull-assistant
Copy link
Copy Markdown

pull-assistant Bot commented Nov 15, 2019

Score: 0.94

Best reviewed: commit by commit


Optimal code review plan (8 warnings)

     Add server module

Rework ierarchy of `protocol` Server in order to be more logical

...rotocol/netty/NettyServer.java 53% changes removed in Resolve problems wit...

...hannel/ChannelInitializer.java 50% changes removed in Merge remote-trackin...

...col/server/AbstractServer.java 82% changes removed in Merge pull request #...

     Add Guava dependency to module-api

Force usage of `Set` as `AbstractModuleLoader`'s backend

...eapi/AbstractModuleLoader.java 53% changes removed in Rework ModuleLoader ...

     Make docs of ModuleLoaders' M generic more clear

     Add SimpleModuleLoader

     Add feather-core dependencies to server

     Add annotation dependencies to server

     Add root FeatherServer API components

     Remove delegate in interface FeatherServer

Merge remote-tracking branch 'origin/server-api' into server-api

...hannel/ChannelInitializer.java 50% changes removed in Merge pull request #...

...rotocol/netty/NettyServer.java 42% changes removed in Resolve problems wit...

...eapi/AbstractModuleLoader.java 50% changes removed in Rework ModuleLoader ...

     Enable usage of Sonatype snapshots repo

     Add Guava dependency to shared

     Add test dependencies to shared

     Implement InvokeUtil

     Add test dependencies to protocol

     Rework PacketType to allow annotation-based registration

     Add @PacketId annotations to all packets

     Use final in catch of SimpleEventManager

     Replace NamedThreadFactory with ThreadFactories

     Suppress redundant cast inspection in CommonHandshakePacketRegistry

Refactor `SharedNettyResources`

...impleSharedNettyResources.java 55% changes removed in Refactor and fix `Sh...

...util/SharedNettyResources.java 60% changes removed in Merge branch 'refact...

Refactor `TransportType`

.../netty/util/TransportType.java 50% changes removed in Merge branch 'refact...

     Add other constructors to PacketHandleException

     Bump lombok from 1.18.8 to 1.18.10

     Merge branch 'development' into refactoring

     Refactor and fix SharedNettyResources amd related

Merge branch 'refactoring' into server-api

.floo 67% changes removed in Merge pull request #...

...rotocol/netty/NettyServer.java 82% changes removed in Resolve problems wit...

Merge pull request #32 from feather-core/server-api

...eapi/AbstractModuleLoader.java 50% changes removed in Rework ModuleLoader ...

Resolve problems with NettyServer infrastructure

...pleMinecraftFeatherServer.java 50% changes removed in Use factory methods ...

     Merge pull request #64 from feather-core/development

     Add jupiter-params to module-loader

     Rework ModuleLoader API

     Remind myself about docs of AbstractModuleLoader

     Use factory methods for SimpleModuleLoader

     Add padla version to POM

     Add java-commons and reflector dependencies

     Add padla dependencies to modules with legacy classes continued in i...

     Replace legacy classes with their continuations from padla

     Merge pull request #50 from feather-core/dependabot/maven/development/...

     Bump lombok from 1.18.8 to 1.18.10

     Merge pull request #66 from feather-core/dependabot/maven/development/...

Powered by Pull Assistant. Last update be2cf89 ... 06c7dcf. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants