fix: Fix Shared SQL/Snowflake registry crashes on cross-project UDF deserialization#6427
Merged
Merged
Conversation
ntkathole
force-pushed
the
fix_shared_project_udf
branch
3 times, most recently
from
May 21, 2026 12:18
6221445 to
8dceb9d
Compare
franciscojavierarceo
approved these changes
May 21, 2026
ntkathole
force-pushed
the
fix_shared_project_udf
branch
3 times, most recently
from
May 21, 2026 13:30
3693501 to
71c3c95
Compare
…ation in proto cache building Signed-off-by: ntkathole <[email protected]>
ntkathole
force-pushed
the
fix_shared_project_udf
branch
from
May 21, 2026 14:01
71c3c95 to
263c52e
Compare
Signed-off-by: ntkathole <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When multiple Feast projects share a single registry (PostgreSQL, S3, or Snowflake), operations like feast apply, REST API listing (/features/all), and UI dashboard crash with ModuleNotFoundError because the registry eagerly deserializes UDFs (via dill.loads()) from all projects — including those whose Python modules aren't installed in the current environment.
This PR fixes the crash at two layers:
Layer 1: Cache building (proto() method) — SQL & Snowflake registries
Layer 2: REST API / gRPC listing — All registry types
(ListFeatureViews, ListStreamFeatureViews, ListOnDemandFeatureViews, ListAllFeatureViews, ListFeatures)pass skip_udf=True so metadata listing never triggers dill.loads().