feat: Add DAX (DynamoDB Accelerator) support for online store#6133
Draft
abhijeet-dhumal wants to merge 4 commits intofeast-dev:masterfrom
Draft
feat: Add DAX (DynamoDB Accelerator) support for online store#6133abhijeet-dhumal wants to merge 4 commits intofeast-dev:masterfrom
abhijeet-dhumal wants to merge 4 commits intofeast-dev:masterfrom
Conversation
Signed-off-by: abhijeet-dhumal <[email protected]>
DAX does not support control plane operations like DescribeTable, CreateTable, or DeleteTable. These must use the regular DynamoDB client regardless of whether DAX is enabled for data operations. This fix ensures: - update() method uses regular DynamoDB for table existence checks and creation - teardown() method uses regular DynamoDB for table deletion - online_read() and online_write_batch() continue to use DAX for data ops
The _get_dynamodb_client/resource methods cache the first client created. When update() creates a non-DAX client first, it gets cached and reused by online_read() even when DAX is enabled. Fix: Use _initialize_dynamodb_* directly in update() and teardown() to create fresh non-cached clients, allowing the cached versions to be created by data operations (online_read/online_write) with DAX enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds native support for Amazon DynamoDB Accelerator (DAX) to the DynamoDB online store, enabling sub-millisecond read latency for cached items.
##Configuration Options
Implementation
Dependencies
Usage
Which issue(s) this PR fixes:
#6059
Misc