Skip to content

fix: Added missing jackc/pgx/v5 entries#6094

Merged
ntkathole merged 1 commit intofeast-dev:masterfrom
ntkathole:fix_go_deps
Mar 11, 2026
Merged

fix: Added missing jackc/pgx/v5 entries#6094
ntkathole merged 1 commit intofeast-dev:masterfrom
ntkathole:fix_go_deps

Conversation

@ntkathole
Copy link
Member

@ntkathole ntkathole commented Mar 11, 2026

What this PR does / why we need it:

PR #5925 inadvertently removed the jackc/pgx/v5 entries.

17 8.034 go/internal/feast/onlinestore/postgresonlinestore.go:13:2: missing go.sum entry for module providing package github.com/jackc/pgx/v5/pgxpool (imported by github.com/feast-dev/feast/go/internal/feast/onlinestore); to add:
#17 8.034 	go get github.com/feast-dev/feast/go/internal/feast/onlinestore
#17 ERROR: process "/bin/sh -c go build -o feast ./go/main.go" did not complete successfully: exit code: 1
------
 > [12/12] RUN go build -o feast ./go/main.go:
6.547 go: downloading golang.org/x/text v0.31.0
7.177 go: downloading github.com/spiffe/go-spiffe/v2 v2.5.0
7.224 go: downloading github.com/cncf/xds/go v0.0.0-20250501225837-2ac532fd4443
7.258 go: downloading github.com/envoyproxy/protoc-gen-validate v1.2.1
7.306 go: downloading github.com/go-jose/go-jose/v4 v4.1.2
7.308 go: downloading github.com/zeebo/errs v1.4.0
7.309 go: downloading cel.dev/expr v0.24.0
7.316 go: downloading golang.org/x/crypto v0.45.0
8.034 go/internal/feast/onlinestore/postgresonlinestore.go:13:2: missing go.sum entry for module providing package github.com/jackc/pgx/v5/pgxpool (imported by github.com/feast-dev/feast/go/internal/feast/onlinestore); to add:
8.034 	go get github.com/feast-dev/feast/go/internal/feast/onlinestore
------
Dockerfile:24
--------------------
  22 |     
  23 |     # Build the Go application
  24 | >>> RUN go build -o feast ./go/main.go
  25 |     
  26 |     # Expose ports
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c go build -o feast ./go/main.go" did not complete successfully: exit code: 1
make: *** [Makefile:722: build-go-feature-server-docker] Error 1

Fixes https://github.com/feast-dev/feast/actions/runs/22921759394/job/66569273941


Open with Devin

@ntkathole ntkathole self-assigned this Mar 11, 2026
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@ntkathole ntkathole merged commit 94ad0e7 into feast-dev:master Mar 11, 2026
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants