Skip to content

Enhance job api to return associated feature table and start time#1259

Merged
pyalex merged 8 commits into
feast-dev:masterfrom
khorshuheng:jobservice-api
Jan 12, 2021
Merged

Enhance job api to return associated feature table and start time#1259
pyalex merged 8 commits into
feast-dev:masterfrom
khorshuheng:jobservice-api

Conversation

@khorshuheng

@khorshuheng khorshuheng commented Jan 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Signed-off-by: Khor Shu Heng [email protected]

What this PR does / why we need it:
As part of an effort to create an UI for Feast, the JobService API needs to return more information, in particular, job start time and the feature table associated with the ingestion jobs.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

gRPC responses for submitting spark jobs via job service now have additional fields: start time for all types of jobs, and feature table for ingestion jobs. These fields have also been added to the corresponding Job object returned by list_jobs and get_job API.

@khorshuheng khorshuheng added the kind/feature New feature or request label Jan 8, 2021
pyalex
pyalex reviewed Jan 11, 2021
View reviewed changes
Comment thread protos/feast/core/JobService.proto Outdated
pyalex
pyalex reviewed Jan 11, 2021
View reviewed changes
Comment thread protos/feast/core/JobService.proto Outdated
@khorshuheng
Rename fields
ab30494 
Signed-off-by: Khor Shu Heng <[email protected]>
@khorshuheng
Add log uri as fields for retreived job
80ac0a8 
Signed-off-by: Khor Shu Heng <[email protected]>
@pyalex

pyalex commented Jan 11, 2021

Copy link
Copy Markdown
Collaborator

/test test-end-to-end-aws

pyalex
pyalex reviewed Jan 11, 2021
View reviewed changes
Comment thread sdk/python/feast/job_service.py Outdated
@khorshuheng
Cast optional str to str type
c5b4e98 
Signed-off-by: Khor Shu Heng <[email protected]>
@khorshuheng

khorshuheng commented Jan 11, 2021

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-gcp

@feast-ci-bot

feast-ci-bot commented Jan 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@khorshuheng: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-azure c5b4e98 link /test test-end-to-end-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feast-ci-bot

feast-ci-bot commented Jan 12, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex

pyalex commented Jan 12, 2021

Copy link
Copy Markdown
Collaborator

/lgtm

@pyalex
pyalex merged commit f4f345e into feast-dev:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyalex pyalex pyalex approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@pyalex pyalex

Labels

approved kind/feature New feature or request lgtm release-note size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khorshuheng @pyalex @feast-ci-bot