Skip to content

Update prow config and makefile#1024

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:remove-e2e-batch
Oct 5, 2020
Merged

Update prow config and makefile#1024
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
terryyylim:remove-e2e-batch

Conversation

@terryyylim

@terryyylim terryyylim commented Oct 5, 2020

Copy link
Copy Markdown
Member

What this PR does / why we need it:
This PR removes e2e batch tests from prow, and updates linting for e2e bq pytests.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

khorshuheng
khorshuheng reviewed Oct 5, 2020
View reviewed changes
Comment thread .prow/config.yaml Outdated
@terryyylim

terryyylim commented Oct 5, 2020

Copy link
Copy Markdown
Member Author

/retest

@khorshuheng khorshuheng self-assigned this Oct 5, 2020
@khorshuheng

khorshuheng commented Oct 5, 2020

Copy link
Copy Markdown
Collaborator

/lgtm

@terryyylim

terryyylim commented Oct 5, 2020

Copy link
Copy Markdown
Member Author

/retest

@feast-ci-bot

feast-ci-bot commented Oct 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@terryyylim: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end 3933c31 link /test test-end-to-end

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@terryyylim

terryyylim commented Oct 5, 2020

Copy link
Copy Markdown
Member Author

/retest

@khorshuheng

khorshuheng commented Oct 5, 2020

Copy link
Copy Markdown
Collaborator

/approve

@khorshuheng
khorshuheng self-requested a review October 5, 2020 07:51
@feast-ci-bot

feast-ci-bot commented Oct 5, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, terryyylim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit 8bf55de into feast-dev:master Oct 5, 2020
@feast-ci-bot

feast-ci-bot commented Oct 5, 2020

Copy link
Copy Markdown
Collaborator

@terryyylim: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml
Details

In response to this:

What this PR does / why we need it:
This PR removes e2e batch tests from prow, and updates linting for e2e bq pytests.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khorshuheng khorshuheng khorshuheng approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@pyalex pyalex Awaiting requested review from pyalex
@woop woop Awaiting requested review from woop
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@khorshuheng khorshuheng

Labels

approved kind/housekeeping lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@terryyylim @khorshuheng @feast-ci-bot