ci: Use testcontainers to spin up DynamoDB instances for local integration tests (#2531)

TremaMiguel · web-flow · commit 695f5dd32e6e · 2022-04-13T08:28:40.000-07:00
* feat: DynamoDBOnlineStoreCreator

Signed-off-by: Miguel Trejo &lt;armando.trejo.marrufo@gmail.com&gt;

* fix: DynamoDBOnlineStoreCreator return endpoint_url and aws region

Signed-off-by: Miguel Trejo &lt;armando.trejo.marrufo@gmail.com&gt;
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -171,6 +171,7 @@ These tests create new temporary tables / datasets locally only, and they are cl
 
 The services with containerized replacements currently implemented are:
 - Datastore
+- DynamoDB
 - Redis
 
 You can run `make test-python-integration-container` to run tests against the containerized versions of dependencies.
diff --git a/sdk/python/tests/integration/feature_repos/repo_configuration.py b/sdk/python/tests/integration/feature_repos/repo_configuration.py
@@ -48,6 +48,9 @@
 from tests.integration.feature_repos.universal.online_store.datastore import (
     DatastoreOnlineStoreCreator,
 )
+from tests.integration.feature_repos.universal.online_store.dynamodb import (
+    DynamoDBOnlineStoreCreator,
+)
 from tests.integration.feature_repos.universal.online_store.redis import (
     RedisOnlineStoreCreator,
 )
@@ -131,7 +134,10 @@
 
 if os.getenv("FEAST_LOCAL_ONLINE_CONTAINER", "False").lower() == "true":
     replacements = {"datastore": DatastoreOnlineStoreCreator}
-    replacement_dicts = [(REDIS_CONFIG, RedisOnlineStoreCreator)]
+    replacement_dicts = [
+        (REDIS_CONFIG, RedisOnlineStoreCreator),
+        (DYNAMO_CONFIG, DynamoDBOnlineStoreCreator),
+    ]
     for c in FULL_REPO_CONFIGS:
         if isinstance(c.online_store, dict):
             for _replacement in replacement_dicts:
diff --git a/sdk/python/tests/integration/feature_repos/universal/online_store/dynamodb.py b/sdk/python/tests/integration/feature_repos/universal/online_store/dynamodb.py
@@ -0,0 +1,34 @@
+from typing import Dict
+
+from testcontainers.core.container import DockerContainer
+from testcontainers.core.waiting_utils import wait_for_logs
+
+from tests.integration.feature_repos.universal.online_store_creator import (
+    OnlineStoreCreator,
+)
+
+
+class DynamoDBOnlineStoreCreator(OnlineStoreCreator):
+    def __init__(self, project_name: str):
+        super().__init__(project_name)
+        self.container = DockerContainer(
+            "amazon/dynamodb-local:latest"
+        ).with_exposed_ports("8000")
+
+    def create_online_store(self) -> Dict[str, str]:
+        self.container.start()
+        log_string_to_wait_for = (
+            "Initializing DynamoDB Local with the following configuration:"
+        )
+        wait_for_logs(
+            container=self.container, predicate=log_string_to_wait_for, timeout=5
+        )
+        exposed_port = self.container.get_exposed_port("8000")
+        return {
+            "type": "dynamodb",
+            "endpoint_url": f"http://localhost:{exposed_port}",
+            "region": "us-west-2",
+        }
+
+    def teardown(self):
+        self.container.stop()
