fix: update default values for ApplyDataSourceRequestBody and ApplyFeatureViewRequestBody

rohit-bharmal · rohit-bharmal · commit 4229f45ae5cb · 2026-05-18T20:46:15.000+05:30
Signed-off-by: Rohit Bharmal &lt;rohitbharmal123@gmail.com&gt;
diff --git a/sdk/python/feast/api/registry/rest/data_sources.py b/sdk/python/feast/api/registry/rest/data_sources.py
@@ -63,7 +63,7 @@ class SparkOptionsModel(BaseModel):
 class ApplyDataSourceRequestBody(BaseModel):
     name: str
     project: str
-    type: Optional[int] = 1
+    type: Optional[int] = None
     timestamp_field: Optional[str] = ""
     created_timestamp_column: Optional[str] = ""
     description: Optional[str] = ""
@@ -212,13 +212,14 @@ def get_data_source(
     def apply_data_source(body: ApplyDataSourceRequestBody):
         ds_proto = DataSourceProto(
             name=body.name,
-            type=body.type or 1,  # type: ignore[arg-type]
             timestamp_field=body.timestamp_field or "",
             created_timestamp_column=body.created_timestamp_column or "",
             description=body.description or "",
             tags=body.tags or {},
             owner=body.owner or "",
         )
+        if body.type is not None:
+            ds_proto.type = body.type  # type: ignore[assignment]
 
         if body.file_options:
             ds_proto.file_options.uri = body.file_options.uri
diff --git a/sdk/python/feast/api/registry/rest/feature_views.py b/sdk/python/feast/api/registry/rest/feature_views.py
@@ -40,7 +40,7 @@ class ApplyFeatureViewRequestBody(BaseModel):
     entities: Optional[List[str]] = []
     features: Optional[List[FeatureModel]] = []
     batch_source: Optional[str] = ""
-    ttl_seconds: Optional[int] = 0
+    ttl_seconds: Optional[int] = None
     online: Optional[bool] = True
     description: Optional[str] = ""
     tags: Optional[Dict[str, str]] = {}
@@ -313,7 +313,9 @@ def apply_feature_view(body: ApplyFeatureViewRequestBody):
             DataSourceProto(name=body.batch_source) if body.batch_source else None
         )
 
-        ttl = Duration(seconds=body.ttl_seconds) if body.ttl_seconds else None
+        ttl = (
+            Duration(seconds=body.ttl_seconds) if body.ttl_seconds is not None else None
+        )
 
         spec = FeatureViewSpec(
             name=body.name,
@@ -324,7 +326,7 @@ def apply_feature_view(body: ApplyFeatureViewRequestBody):
             description=body.description or "",
             owner=body.owner or "",
         )
-        if ttl:
+        if ttl is not None:
             spec.ttl.CopyFrom(ttl)
         if batch_source_proto:
             spec.batch_source.CopyFrom(batch_source_proto)
