Conversation
|
Actually ASFileParser is parsing the declarations correctly (it only misses the escaped quotes in the string value). Our implementation of |
|
The escaped quotes were what I was referring to when I said it doesn't play nice with that :) |
|
Let's say that it's complicated - this has grown organically, based on the initial choice that using a proper parser with AST and all was a complexity we couldn't afford (it really has considerable consequences). So ASFileParser only builds superficial models and ASComplete has to do some local parsing. That kind of crappy I admit. Now the real problem here is the method's hint highlighting: it is applied on the text of the hint (which requires parsing) instead of the hint text+highlighting tags being constructed from the method's model that we have also at this point in the code. |
Also discovered that the ASFileParser does not seem to play nice with stuff like
But that thing looked far too monolithic and scary to attempt working that out...
Anyways, for the issue posted in the forum (http://www.flashdevelop.org/community/viewtopic.php?f=6&t=11969), this fix should be fine, and if the ASFileParser gets an update to deal with escaped quotation marks inside default parameters, this fix should still be fine since it takes escaping into account :)