Conversation
| } | ||
|
|
||
| int style = Sci.StyleAt(funcBodyStart + lastPos) & stylemask; | ||
| if (ASComplete.IsCommentStyle(style)) |
There was a problem hiding this comment.
Looking generally alright, but don't we want to keep some of these conditions?
There was a problem hiding this comment.
The only condition is that we are interested in right now checking for comments.
|
Really nice to see an unit test for this PR. Do you think you could make some more? Since this is a untested generator I'm sure there are a lot of cases to add. Not asking for every possible case, of course, just the main ones that you can come of, and surely you can come up with some other failing or missing cases. |
|
@Neverbirth yes, I'm going to do yet. |
SlavaRa
changed the title
|
@elsassph @Neverbirth guys, I have to do something for this issue? Or I can add new tests and functionality in a separate issue(for example a clear indication to the type for AS3)? |
|
I'd prefer to see more tests in this PR, because it will show that both the new, improved, behaviour, and the old ones, still work, and maybe fix even more things before merging. |
|
Ok, I add in the near future |
|
I added the test cases to test the extract local variable for situations that I face every day on the main work. |
|
Conflict. |
…nto feature/ExtractLocalVariable_improvements
|
@elsassph fixed. |
3 participants
Before commit:
After: ASCompletion.Tests/Test Files/generated/haxe/AfterGenerateExtractVariableGeneric.hx