Merged
Conversation
Member
Author
|
added a simple example with trivially "synced" selectors: unit_circle-2025-03-03_22.50.14.mp4 |
Member
Author
|
The decorator is working as expected and exceptions are also raised correctly, @clewis7 if you can test on your end too it should be gtg! This is probably my favorite PR, small few lines decorator that makes life so much easier 🥳 |
This was referenced Mar 4, 2025
clewis7
reviewed
Mar 5, 2025
Member
clewis7
left a comment
There was a problem hiding this comment.
super cool! might need to run the docs to update API?
Member
Author
|
No API changes here. |
clewis7
approved these changes
Mar 5, 2025
This was referenced May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple decorator applied on all the
GraphicFeature.set_value()methods should allow us to create complex event graphs with cycles. Users don't have to think about managing bidirectional events 😄related #741
Example:
Need to test with more graphics and also test when exceptions are raised in
GraphicFeature.set_value()@apasarkar @FlynnOConnell you guys will love this!