remove ipywidget code from selectors and cleanup docstrings#644
Merged
remove ipywidget code from selectors and cleanup docstrings#644
Conversation
Member
Author
|
Forgot to regen API docs, I really need to use precommit |
kushalkolar
force-pushed
the
remove-ipywidget-code
branch
from
33fad93 to
4660257
Compare
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/remove-ipywidget-code |
Member
Author
|
@clewis7 gtg after review, I removed ipywidget code within the selectors but I also cleaned up the docstrings, there were some remnants stating "slider" from over a year ago. |
clewis7
approved these changes
Oct 17, 2024
Member
clewis7
left a comment
clewis7
left a comment
There was a problem hiding this comment.
LGTM
I don't know if you want to do this in this PR or a different PR but we had talked about making fill_color, vertex_color, and edge_color properties (re: issue with kevin's viz when changing the selector colors and then events set them back to original)
Member
Author
|
Let's do that separately |
FlynnOConnell
pushed a commit
to FlynnOConnell/fastplotlib
that referenced
this pull request
Jan 7, 2025
…lib#644) * remove ipywidget code from linear selector and cleanup docstrings * remove ipywidget code from LinearRegionSelector, cleanup docstrings * remove a method * update API docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since we've not switched to imgui we shouldn't have any GUI specific code in the core library, this really cleans up the selectors 😄