Skip to content

Allow users to opt out of literal comma "," query parameters parsing#215

Merged
adrai merged 2 commits intofastify:masterfrom
mouhannad-sh:parseCommaSeparatedQueryParams
May 13, 2024
Merged

Allow users to opt out of literal comma "," query parameters parsing#215
adrai merged 2 commits intofastify:masterfrom
mouhannad-sh:parseCommaSeparatedQueryParams

Conversation

@mouhannad-sh
Copy link
Copy Markdown
Contributor

Fixes #202 by adding a new optional option parseCommaSeparatedQueryParams to opt-out from parsing multi-value query params with api gateway v2.0 format.

Additionally fixes a bug where the lambda incoming event argument was manipulated during the parsing. This may cause confusion for users attempting to log the original lambda argument when using request.awsLambda.event.queryStringParameters

Checklist

… multi-value query params with api gateway v2.0 format, fixes fastify#202
@adrai
Copy link
Copy Markdown
Member

adrai commented May 13, 2024

Can you extend the readme accordingly?

@mouhannad-sh
Copy link
Copy Markdown
Contributor Author

Updated the readme, thanks !

@adrai adrai merged commit 5ccea91 into fastify:master May 13, 2024
@adrai
Copy link
Copy Markdown
Member

adrai commented May 13, 2024

included in v4.1.0
thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect splitting of query parameters parameters containing literal commas

2 participants