Skip to content

Created LEARNING.md and TESTS.md. - #293

Merged
behrtam merged 1 commit into
exercism:masterfrom
oalbe:master
Feb 15, 2016
Merged

behrtam merged 1 commit into
exercism:masterfrom
oalbe:master

Conversation

@oalbe

@oalbe oalbe commented Jan 26, 2016

Copy link
Copy Markdown
Contributor

Here for reference, because I messed up and had to reset the fork.

@kytrinyx I'm sorry, this is the only solution that worked... I'll pay more attention next time.

@behrtam

behrtam commented Feb 1, 2016

Copy link
Copy Markdown
Contributor

pip is already installed if you're using Python 2 >=2.7.9 or Python 3 >=3.4 ... https://pip.pypa.io/en/stable/installing/

So it's not totally true to say it only comes with Python3. I wouldn't mention it, because almost all should have it bundled with their python.

... install pytest though pip ...

small typo -> through or with

This because in the latter case pytest will just return a positive result, only specifying that it ran zero tests.

I would rewrite that one a bit. Maybe ... "If you test your implementation (bob.py) instead of the test suite (bob_test.py), it will return a positive result because it contains no test cases. It looks like this:" ... but writing english is not really a skill of mine.

@oalbe

oalbe commented Feb 1, 2016

Copy link
Copy Markdown
Contributor Author

@behrtam I'll fix those things asap, thanks for the corrections. Though it would still be nice to have a native speaker proofread it anyway.

@oalbe

oalbe commented Feb 1, 2016

Copy link
Copy Markdown
Contributor Author

@behrtam Let me know how it looks to you now.

@behrtam

behrtam commented Feb 1, 2016

Copy link
Copy Markdown
Contributor

Could you please squash the two commits to a single one and while you do this you can also update your commit msg (imperative mood and no period #more).

@oalbe

oalbe commented Feb 2, 2016

Copy link
Copy Markdown
Contributor Author

@behrtam Better? Thanks for the link, I had no idea about those punctuation and mood rules.

behrtam added a commit that referenced this pull request Feb 15, 2016
Created LEARNING.md and TESTS.md.
@behrtam
behrtam merged commit d3383e9 into exercism:master Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants