rectangles: Change empty string test cases into empty list#263
Closed
monzee wants to merge 2 commits intoexercism:masterfrom
Closed
rectangles: Change empty string test cases into empty list#263monzee wants to merge 2 commits intoexercism:masterfrom
monzee wants to merge 2 commits intoexercism:masterfrom
Conversation
Contributor
That should delete the last commit. You should probably save it first, so you can submit it in a second pr. |
Author
|
Alright, I'm withdrawing this and will try again tomorrow. |
Member
|
@monzee for fututre reference, if you do a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test cases with strings as input make no sense in this exercise as there is no happy path at all for just strings. All inputs are expected to be lists of strings. If one practices TDD, these cases would make one start off the wrong foot (especially since these are at the top) writing handlers for strings.
Also included in this PR are minor changes in the example solution. I didn't really mean to include this but I don't know how to split it off.